[5.x] Allow closure in cascade content hydration #13580
Merged
+30
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcorieser
changed the title
marcorieser
deleted the
feat/allow-closure-in-cascade-content-hydration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We (Jack Sleight and I) are currently adding support for hydrating the Cascade between subsequent requests in Livewire. Right now, the logic to hydrate the content runs for all subsequent requests, even if the Cascade does not get hydrated in the request:
https://github.com/jacksleight/statamic-livewire/blob/5e598375c06ecfd5bf40b6bad3e8878feb7f3f51/src/Http/Middleware/HydrateCascadeByLivewireUrl.php#L42
So I thought, adding support for a closure could prevent that.
I wonder if
Cascade::content()should return the property as is or evaluate the potential closure.